Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enum check from remove contract #6053

Closed
wants to merge 1 commit into from
Closed

Remove enum check from remove contract #6053

wants to merge 1 commit into from

Conversation

janezpodhostnik
Copy link
Contributor

The removal is done here: onflow/cadence#3402

context: https://dapperlabs.slack.com/archives/CUU2KQL4A/p1714745625179679?thread_ts=1714653448.424269&cid=CUU2KQL4A

❗️DO NOT MERGE - this is special-case change to update EVM contract on previewnet only.

@janezpodhostnik janezpodhostnik requested a review from sideninja June 6, 2024 19:15
@janezpodhostnik janezpodhostnik self-assigned this Jun 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.72%. Comparing base (0658967) to head (4a9aefc).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6053   +/-   ##
=======================================
  Coverage   41.72%   41.72%           
=======================================
  Files        1962     1962           
  Lines      138159   138159           
=======================================
+ Hits        57640    57647    +7     
+ Misses      74531    74525    -6     
+ Partials     5988     5987    -1
Flag Coverage Δ
unittests 41.72% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideninja sideninja Awaiting requested review from sideninja

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee Kay-Zee will be requested when the pull request is marked ready for review Kay-Zee is a code owner

Assignees

@janezpodhostnik janezpodhostnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janezpodhostnik @codecov-commenter